Merged
Conversation
- Remove mix for int/long - Migrate to dynamic `next` for most entities except exts and direct children that must be the same on both sides
ulex
reviewed
Mar 2, 2026
ForNeVeR
reviewed
Mar 4, 2026
rd-kt/rd-framework/src/main/kotlin/com/jetbrains/rd/framework/impl/RdProperty.kt
Show resolved
Hide resolved
ForNeVeR
approved these changes
Mar 4, 2026
Document the two child RdId generation strategies (hash-based via Mix/mix and dynamic via Next/next) controlled by the stable parameter, and how entities like RdExtBase can override it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Decimal strings for consecutive indices ("0", "1", "2", ...) are very
short and similar, leading to poor hash distribution. Binary representation
produces more varied strings (e.g. 7→"111", 8→"1000"), improving RdId
uniqueness.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ForNeVeR
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextfor most entities except exts and direct children that must be the same on both sides